From e1701f80383cdd8820ba135d74ef51c8bb3fad9d Mon Sep 17 00:00:00 2001
From: Jaap van Ekris <82339657+JaapvanEkris@users.noreply.github.com>
Date: Thu, 27 Apr 2023 17:54:20 +0200
Subject: [PATCH] Fixes a timer bug, improves function naming

Fixes a bug in the timer visual that made it go from 0:59 to 0:00 to 1:00, which is extremely confusing, especially for the total time and the pace.
Fixes the name, as it used to be secondsToPace, and was used for totalTime as well.
---
 app/client/store/dashboardMetrics.js | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/app/client/store/dashboardMetrics.js b/app/client/store/dashboardMetrics.js
index d5e94f6..3552840 100644
--- a/app/client/store/dashboardMetrics.js
+++ b/app/client/store/dashboardMetrics.js
@@ -1,5 +1,5 @@
 import { html } from 'lit'
-import { formatDistance, formatNumber, secondsToPace } from '../lib/helper'
+import { formatDistance, formatNumber, secondsToTimeString } from '../lib/helper'
 import { icon_bolt, icon_clock, icon_fire, icon_heartbeat, icon_paddle, icon_route, icon_stopwatch, rower_icon } from '../lib/icons'
 import '../components/DashboardForceCurve.js'
 import '../components/DashboardActions.js'
@@ -18,7 +18,7 @@ export const DASHBOARD_METRICS = {
     }
   },
 
-  pace: { displayName: 'Pace/500', size: 1, template: (metrics, config) => simpleMetricFactory(secondsToPace(500 / metrics?.cycleLinearVelocity), '/500m', config.guiConfigs.showIcons ? icon_stopwatch : '') },
+  pace: { displayName: 'Pace/500', size: 1, template: (metrics, config) => simpleMetricFactory(secondsToTimeString(500 / metrics?.cycleLinearVelocity), '/500m', config.guiConfigs.showIcons ? icon_stopwatch : '') },
 
   power: { displayName: 'Power', size: 1, template: (metrics, config) => simpleMetricFactory(formatNumber(metrics?.cyclePower), 'watt', config.guiConfigs.showIcons ? icon_bolt : '') },
 
@@ -51,7 +51,7 @@ export const DASHBOARD_METRICS = {
     template: (metrics, config) => {
       const time = metrics?.sessiontype === 'Time' ? Math.max(metrics?.intervalTargetTime - metrics?.intervalMovingTime, 0) : metrics?.totalMovingTime
 
-      return simpleMetricFactory(secondsToPace(time ?? 0), '', config.guiConfigs.showIcons ? icon_clock : '')
+      return simpleMetricFactory(secondsToTimeString(time ?? 0), '', config.guiConfigs.showIcons ? icon_clock : '')
     }
   },