* Improvement of the startup behaviour
These changes improve the startup behaviour: ORM will now always start with a detected drive-phase, which will trigger recording etc. This changes several initialisations of variables to make sure they enable the triggering of a "Drive" at the beginning of a stroke. Also workoutHandler.handleStrokeEnd has been renamed to workoutHandler.handleDriveEnd, as this is the clear end of that stroke-phase.
* Renamed handleStrokeEnd to handleDriveEnd
Renamed handleStrokeEnd to handleDriveEnd, as this is the clear end of that stroke-phase, as the current model alternates between Drive+Recovery and Recovery+Drive strokes to keep feeding the metrics, there isn't a very clear "End of the Stroke".
* Redefinition of a stroke
Traditionally, a stroke is defined as a Drive phase, followed by a Recovery Phase. This is also expected by Garmin and EXR as Concept2 implements it this way as well. This implementation makes it more consistent with that interpretation, while leaving room for intermediate updates. This should make Bluetooth behaviour and metrics recording more consistent.
* Update to accomodate the new RowingEngine
Update of the MovingFlankDetector to provide the values needed to determine the speeds at the beginning of the flank.
* Created the MovingAverager for RowingEngine 2.0
Added the MovingAverager to accomodate the RowingEngine 2.0
* Update to RowingEngine 2.0
Update based on the great theoretical work of Anu Dudhia and the practical experiences of Dave Venrooy.
* Added to explain RowingEngine 2.0 design
A rationale for explaining the RowingEngine 2.0 design, based on the great theoretical work of Anu Dudhia, and the practical work of Dave Venrooy and Marinus van Holst, as well as the great feedback from Lars Berning.
* Update to accomodate the new RowingEngine
Update to the rower settings to accommodate the new RowingEngine. Please note that the modifications need to be verified by the respective users.
* Modifications to the RX800 tests
Modifications to the RX800 to bring it in line with the Concept2 Power and distance measurements.
* BUGFIX: Prevent ghost-strokes at end of session
This change to isAccelerating prevents stroke-detection to detect a stroke when the currentDt "flatlines". This typically happens when the error correction kicks in when you quit rowing (and thus the rowerSettings.maximumTimeBetweenImpulses is exceeded). It is bad (flatlining isn't acceleration), and this ghost-stroke causes havoc in the GUI: all measurements are reset again to random values instead of the nice indicators normally used.
* BUGFIX: Prevent ghost-strokes at end of session
This change to isAccelerating prevents stroke-detection to detect a stroke when the currentDt "flatlines". This typically happens when the error correction kicks in when you quit rowing (and thus the rowerSettings.maximumTimeBetweenImpulses is exceeded). It is bad (flatlining isn't acceleration), and this ghost-stroke causes havoc in the GUI: all measurements are reset again to random values instead of the nice indicators normally used.
* Added defensive programming
In some rare cases not rounding led to a buffer overflow, so added defensive programming to prevent this.
* Update MovingFlankDetector.js
* Improved stroke detection algorithm accuracy
Improvement of the Stroke detection algorithm: when naturalDeceleration is specified in the settings, it will only consider something a Revocery when this level of deceleration is encountered for the FlankLength.
* Made the RowingEngine more stateful
Removed some bugs, added a lot of defensive programming and made the RowingEngine report the key statistics every impuls to create a more fluid experience on the monitor. To do this, the rowingEngine maintins and reports absolute values to rowingStatistics, instead of relative.
* Improved stroke detection algorithm accuracy
Improvement of the Stroke detection algorithm: when naturalDeceleration is specified in the settings, it will only consider something a Revocery when this level of deceleration is encountered for the FlankLength.
* Modification to fit new RowingEngine
* Addition of new parameters for stroke detection
Added new parameters for stroke detection and monitor fluidity
* Fixed missing bracket
* Updated to more fluid RowingStatistics
Moved the timer from a static timer to the raw measurements of the flywheel, and the distance more frequently updated, to keep all data consistent. Also made the GUI-updates more fluid, responsive and dependent on settings: this more fluid GUI update mechanism is dependent on the screenUpdateInterval setting and moving averager dependent on a setting (numOfPhasesForAveragingScreenData)
* Made all monitor updates consistent
* Accommodate more frequent update of the monitors
Update to accommodate the more frequent updates, and to accommodate the reset for the RowingEngine
* improves some testcases, fixes some minor code styling and duplicate definitions
* Fixed a comment about dragfactor
* Added parameters for the new RowingStatistics.js
Added screenUpdateInterval, numOfPhasesForAveragingScreenData and maxCycleTimeBeforePause as config parameters to remove statically determined parameters in RowingStatistics.js
* Added RX800 as second testbed
* fixes some problems that caused the engine to crash
* uses non sanitized durations for now
* updates some settings, fixes some typos
* wires the correct timer configuration, fixes a problem where SPM would not reset to 0
* fixes a crash problem in workout recorder, fixes fallback value for strokeTime
* relaxes constraint on stroke time
* updates some explanatory text, updates some rower parameters
Co-authored-by: Lars Berning <151194+laberning@users.noreply.github.com>
* Improvement of the MovingflankDetector
Simplified the call of the moving flank detector, making it dependent on the settings
* Update MovingFlankDetector.js
Cleaned up the call to the MovingFlankDetector
* Added heartrate data to TCX
* Added parameters for the flankdetector
Added parameters for the flankdetector (flankLength and numberOfErrorsAllowed)
* Gave the RX800 some room as the settings haven't stabilised yet (and I think the recording is with a different damper setting than the source tree)
Added the flankdetector, to reliably detect an acceleration or deceleration of the flywheel
Added extra metrics for the creation of TCX-files
Added extra metrics (speed in m/s and cadence) to allow future export of this data to Garmin TCX files, which everybody seems to love.
I increased the priority of the GPIO-service, as I noticed that much of the measurement noise originates from delayed read-outs of the GPIO.
An Excel tool to "play" with the settings of a rower, to adjust the settings found in the rowerprofiles.js
Adds test and data for RX800 rower
Lightweight version of Excel file
Co-authored-by: Lars Berning <151194+laberning@users.noreply.github.com>
Lars Berning
Jaap van Ekris