From 28ef311ba5b337a9e0283088825cd92f0dfbe01b Mon Sep 17 00:00:00 2001 From: Christoph Klaffl Date: Thu, 16 Jan 2020 18:10:20 +0100 Subject: [PATCH] only print stderr output of failed listing command with --debug flag --- syncoid | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/syncoid b/syncoid index 9ae3990..ddab82c 100755 --- a/syncoid +++ b/syncoid @@ -1455,8 +1455,13 @@ sub getsnaps() { $fsescaped = escapeshellparam($fsescaped); } - my $getsnapcmd = "$rhost $mysudocmd $zfscmd get -Hpd 1 -t snapshot guid,creation $fsescaped |"; - if ($debug) { print "DEBUG: getting list of snapshots on $fs using $getsnapcmd...\n"; } + my $getsnapcmd = "$rhost $mysudocmd $zfscmd get A-Hpd 1 -t snapshot guid,creation $fsescaped"; + if ($debug) { + $getsnapcmd = "$getsnapcmd |"; + print "DEBUG: getting list of snapshots on $fs using $getsnapcmd...\n"; + } else { + $getsnapcmd = "$getsnapcmd 2>/dev/null |"; + } open FH, $getsnapcmd; my @rawsnaps = ; close FH or do {