cyteen
/
sanoid
mirror of https://github.com/jimsalterjrs/sanoid
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Batch snapshot deletion. 

This is to prevent a problem with a large amount of snapshots which
exceed the allowed shell command length.
This commit is contained in:
Mathieu Arnold 2023-04-08 09:58:40 +02:00
parent f711e6bf28
commit 2f706a4ae1
No known key found for this signature in database
GPG Key ID: 7F620E0A9E9D41BE
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
syncoid
View File

@ -890,8 +890,14 @@ sub syncdataset {
}
if (defined $args{'delete-target-snapshots'}) {
my $snaps = join ',', grep {!exists $snaps{'source'}{$_}} keys %{ $snaps{'target'} };
if ($snaps ne '') {
# Find the snapshots that exist on the target, filter with
# those that exist on the source. Remaining are the snapshots
# that are only on the target. Then sort by creation date, as
# to remove the oldest snapshots first.
my @to_delete = sort { $snaps{'target'}{$a}{'creation'}<=>$snaps{'target'}{$b}{'creation'} } grep {!exists $snaps{'source'}{$_}} keys %{ $snaps{'target'} };
while (@to_delete) {
# Create batch of snapshots to remove
my $snaps = join ',', splice(@to_delete, 0, 50);
my $command;
if ($targethost ne '') {
$command = "$sshcmd $targethost " . escapeshellparam("$targetsudocmd $zfscmd destroy $targetfsescaped\@$snaps");