From d437d9f8df3186aa45166d5b3a3481088313e3fc Mon Sep 17 00:00:00 2001 From: Jim Salter Date: Wed, 28 Dec 2016 10:58:11 -0500 Subject: [PATCH 1/3] Update syncoid --- syncoid | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/syncoid b/syncoid index 31c9955..9c73e23 100755 --- a/syncoid +++ b/syncoid @@ -4,7 +4,7 @@ # from http://www.gnu.org/licenses/gpl-3.0.html on 2014-11-17. A copy should also be available in this # project's Git repository at https://github.com/jimsalterjrs/sanoid/blob/master/LICENSE. -my $version = '1.4.7'; +my $version = '1.4.7a'; use strict; use warnings; @@ -19,6 +19,11 @@ if ($args{'version'}) { exit 0; } +if (!(defined $args{'source'} && defined $args{'target'})) { + print 'usage: syncoid [src_user@src_host:]src_pool/src_fs [dst_user@dst_host:]dst_pool/dst_fs'."\n"; + exit 127; +} + my $rawsourcefs = $args{'source'}; my $rawtargetfs = $args{'target'}; my $debug = $args{'debug'}; From ffa22c910584c7a2d751216f25acdd1796eae7e3 Mon Sep 17 00:00:00 2001 From: Jim Salter Date: Wed, 28 Dec 2016 11:01:11 -0500 Subject: [PATCH 2/3] Update syncoid cause raw invocation to print typical/minimal usage example, as per @rriley and @fajarnugraha suggestions --- syncoid | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/syncoid b/syncoid index 9c73e23..c9b31f2 100755 --- a/syncoid +++ b/syncoid @@ -20,7 +20,7 @@ if ($args{'version'}) { } if (!(defined $args{'source'} && defined $args{'target'})) { - print 'usage: syncoid [src_user@src_host:]src_pool/src_fs [dst_user@dst_host:]dst_pool/dst_fs'."\n"; + print 'usage: syncoid [src_user@src_host:]src_pool/src_dataset [dst_user@dst_host:]dst_pool/dst_dataset'."\n"; exit 127; } From c121305b9d5af6e2b5f5ab96551237b35006840a Mon Sep 17 00:00:00 2001 From: Jim Salter Date: Wed, 28 Dec 2016 11:02:42 -0500 Subject: [PATCH 3/3] Update CHANGELIST --- CHANGELIST | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELIST b/CHANGELIST index 4e80d00..e7e9645 100644 --- a/CHANGELIST +++ b/CHANGELIST @@ -1,3 +1,6 @@ +1.4.7a (syncoid only) added standard invocation output when called without source or target + as per @rriley and @fajarnugraha suggestions + 1.4.7 reverted Perl shebangs to #!/usr/bin/perl - sorry FreeBSD folks, shebanged to /usr/bin/env perl bare calls to syncoid or sanoid (without explicit calls to Perl) don't work on EITHER of our systems. I'm not OK with that, this is going to be an OS localization issue that can either be addressed with BSD-specific packaging, or you can individually address it