From 1767e66220525d2c022f73d40a3a74ead8d8c65b Mon Sep 17 00:00:00 2001
From: SET <salvador@inti.gob.ar>
Date: Fri, 14 Aug 2020 15:58:00 -0300
Subject: [PATCH] Added tests for errors in the libraries components fields

---
 tests/board_samples/error_l3.sch   | 27 +++++++++++++++++++++++++++
 tests/board_samples/error_l4.sch   | 27 +++++++++++++++++++++++++++
 tests/board_samples/l3.lib         | 22 ++++++++++++++++++++++
 tests/board_samples/l4.lib         | 24 ++++++++++++++++++++++++
 tests/board_samples/sym-lib-table  |  2 ++
 tests/test_plot/test_sch_errors.py |  6 ++++++
 6 files changed, 108 insertions(+)
 create mode 100644 tests/board_samples/error_l3.sch
 create mode 100644 tests/board_samples/error_l4.sch
 create mode 100644 tests/board_samples/l3.lib
 create mode 100644 tests/board_samples/l4.lib

diff --git a/tests/board_samples/error_l3.sch b/tests/board_samples/error_l3.sch
new file mode 100644
index 00000000..3bb920a0
--- /dev/null
+++ b/tests/board_samples/error_l3.sch
@@ -0,0 +1,27 @@
+EESchema Schematic File Version 4
+EELAYER 30 0
+EELAYER END
+$Descr A4 11693 8268
+encoding utf-8
+Sheet 1 1
+Title ""
+Date ""
+Rev ""
+Comp ""
+Comment1 ""
+Comment2 ""
+Comment3 ""
+Comment4 ""
+$EndDescr
+$Comp
+L l3:R R1
+U 1 1 5EBE8A2E
+P 3500 2200
+F 0 "R1" H 3570 2246 50  0000 L CNN
+F 1 "100" H 3570 2155 50  0000 L CNN
+F 2 "Resistor_SMD:R_0805_2012Metric" V 3430 2200 50  0001 C CNN
+F 3 "~" H 3500 2200 50  0001 C CNN
+	1    3500 2200
+	1    0    0    -1  
+$EndComp
+$EndSCHEMATC
diff --git a/tests/board_samples/error_l4.sch b/tests/board_samples/error_l4.sch
new file mode 100644
index 00000000..23376f5c
--- /dev/null
+++ b/tests/board_samples/error_l4.sch
@@ -0,0 +1,27 @@
+EESchema Schematic File Version 4
+EELAYER 30 0
+EELAYER END
+$Descr A4 11693 8268
+encoding utf-8
+Sheet 1 1
+Title ""
+Date ""
+Rev ""
+Comp ""
+Comment1 ""
+Comment2 ""
+Comment3 ""
+Comment4 ""
+$EndDescr
+$Comp
+L l4:R R1
+U 1 1 5EBE8A2E
+P 3500 2200
+F 0 "R1" H 3570 2246 50  0000 L CNN
+F 1 "100" H 3570 2155 50  0000 L CNN
+F 2 "Resistor_SMD:R_0805_2012Metric" V 3430 2200 50  0001 C CNN
+F 3 "~" H 3500 2200 50  0001 C CNN
+	1    3500 2200
+	1    0    0    -1  
+$EndComp
+$EndSCHEMATC
diff --git a/tests/board_samples/l3.lib b/tests/board_samples/l3.lib
new file mode 100644
index 00000000..98788d60
--- /dev/null
+++ b/tests/board_samples/l3.lib
@@ -0,0 +1,22 @@
+EESchema-LIBRARY Version 2.4
+#encoding utf-8
+#
+# R
+#
+DEF R R 0 0 N Y 1 F N
+F0 "R"
+F1 "R" 0 0 50 V V C CNN
+F2 "" -70 0 50 V I C CNN
+F3 "" 0 0 50 H I C CNN
+$FPLIST
+ R_*
+ R_*
+$ENDFPLIST
+DRAW
+S -40 -100 40 100 0 1 10 N
+X ~ 1 0 150 50 D 50 50 1 1 P
+X ~ 2 0 -150 50 U 50 50 1 1 P
+ENDDRAW
+ENDDEF
+#
+#End Library
diff --git a/tests/board_samples/l4.lib b/tests/board_samples/l4.lib
new file mode 100644
index 00000000..98ab47b9
--- /dev/null
+++ b/tests/board_samples/l4.lib
@@ -0,0 +1,24 @@
+EESchema-LIBRARY Version 2.4
+#encoding utf-8
+#
+# R
+#
+DEF R R 0 0 N Y 1 F N
+F0 "R" 80 0 50 V V C CNN
+F1 "R" 0 0 50 V V C CNN
+F2 "" -70 0 50 V I C CNN
+F3 "" 0 0 50 H I C CNN
+F4 "" 0 0 50 H I C CNN "T1"
+F5 "" 0 0 50 H I C CNN
+$FPLIST
+ R_*
+ R_*
+$ENDFPLIST
+DRAW
+S -40 -100 40 100 0 1 10 N
+X ~ 1 0 150 50 D 50 50 1 1 P
+X ~ 2 0 -150 50 U 50 50 1 1 P
+ENDDRAW
+ENDDEF
+#
+#End Library
diff --git a/tests/board_samples/sym-lib-table b/tests/board_samples/sym-lib-table
index 207080c7..2211cd5a 100644
--- a/tests/board_samples/sym-lib-table
+++ b/tests/board_samples/sym-lib-table
@@ -1,4 +1,6 @@
 (sym_lib_table
   (lib (name l1)(type Legacy)(uri ${KIPRJMOD}/l1.lib)(options "")(descr ""))
   (lib (name l2)(type Legacy)(uri ${KIPRJMOD}/l2.lib)(options "")(descr ""))
+  (lib (name l3)(type Legacy)(uri ${KIPRJMOD}/l3.lib)(options "")(descr ""))
+  (lib (name l4)(type Legacy)(uri ${KIPRJMOD}/l4.lib)(options "")(descr ""))
 )
diff --git a/tests/test_plot/test_sch_errors.py b/tests/test_plot/test_sch_errors.py
index dd6ce9fd..515e39e1 100644
--- a/tests/test_plot/test_sch_errors.py
+++ b/tests/test_plot/test_sch_errors.py
@@ -53,5 +53,11 @@ def test_sch_errors_l2():
     setup_ctx('l2', 'error_l2', 'Unexpected end of file')
 
 
+def test_sch_errors_l3():
+    setup_ctx('l3', 'error_l3', 'Malformed component field')
+
+
+def test_sch_errors_l4():
+    setup_ctx('l4', 'error_l4', 'Missing component field name')