From 2a0596e3fc9cb9cdbc89a3fc9b962d9882404635 Mon Sep 17 00:00:00 2001 From: "Salvador E. Tropea" Date: Mon, 4 Mar 2024 10:29:49 -0300 Subject: [PATCH] [Update_XML][Fixed] Components excluded from the board reported anyways Closes #585 --- CHANGELOG.md | 1 + kibot/pre_update_xml.py | 2 ++ 2 files changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 866c0321..791890bb 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Netlist generation problems with components on the PCB but not in schematic. (#578) - Filters: _none filter not always honored (i.e. exclude in BoM) (#580) +- PCB Parity: components excluded from the board reported anyways (#585) ## [1.6.4] - 2024-02-02 ### Added diff --git a/kibot/pre_update_xml.py b/kibot/pre_update_xml.py index e4c1a60c..9e471e49 100644 --- a/kibot/pre_update_xml.py +++ b/kibot/pre_update_xml.py @@ -120,6 +120,8 @@ class Update_XML(BasePreFlight): # noqa: F821 for p in set(pcb_props.keys()).difference(found_props): errors.append('{} PCB property `{}` not in schematic'.format(ref, p)) for ref in set(comps.keys()).difference(found_comps): + if 'exclude_from_board' in comps[ref].props: + continue errors.append('{} found in schematic, but not in PCB'.format(ref)) return excluded