From 8f2f59eeb0bd4749c16c0ce49b07857c77256afa Mon Sep 17 00:00:00 2001 From: "Salvador E. Tropea" Date: Mon, 18 Jul 2022 08:07:11 -0300 Subject: [PATCH] [KiBot Check] Added the comments - When a tool is missing. - Currently Pandoc is the only with extra comments Related to #228 --- src/kibot-check | 6 ++++-- src/kibot-check.in | 6 ++++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/kibot-check b/src/kibot-check index f3437d61..d29ddd51 100755 --- a/src/kibot-check +++ b/src/kibot-check @@ -930,7 +930,7 @@ def python_module(severity, name, deb_package, roles): print(RESET) -def binary_tool(severity, name, url, url_down, deb_package, deb, extra_deb, roles, downloader): +def binary_tool(severity, name, url, url_down, deb_package, deb, extra_deb, roles, downloader, comments): if not severity: return print(sev2color(severity)+'* {} not installed or too old'.format(name)) @@ -944,6 +944,8 @@ def binary_tool(severity, name, url, url_down, deb_package, deb, extra_deb, role print(' Visit: '+url) if url_down: print(' Download it from: '+url_down) + for c in comments: + print(' '+c) if isinstance(downloader, dict): print(' This tool might be automatically downloaded by KiBot.') show_roles(roles) @@ -1144,7 +1146,7 @@ for name, d in dependencies.items(): else: # TODO: check pip_ok and if this is a Python tool suggest install pip binary_tool(d['sev'], d['name'], d['url'], d['url_down'], d['deb_package'], d['in_debian'], d['extra_deb'], - d['roles'], d['downloader']) + d['roles'], d['downloader'], d['comments']) labels = ('ok', 'optional for an output', 'optional for general use', 'mandatory for an output', 'mandatory for general use') text = ', '.join([sev2color(c)+l+RESET for c, l in enumerate(labels)]) diff --git a/src/kibot-check.in b/src/kibot-check.in index ae87baf2..12604b80 100755 --- a/src/kibot-check.in +++ b/src/kibot-check.in @@ -229,7 +229,7 @@ def python_module(severity, name, deb_package, roles): print(RESET) -def binary_tool(severity, name, url, url_down, deb_package, deb, extra_deb, roles, downloader): +def binary_tool(severity, name, url, url_down, deb_package, deb, extra_deb, roles, downloader, comments): if not severity: return print(sev2color(severity)+'* {} not installed or too old'.format(name)) @@ -243,6 +243,8 @@ def binary_tool(severity, name, url, url_down, deb_package, deb, extra_deb, role print(' Visit: '+url) if url_down: print(' Download it from: '+url_down) + for c in comments: + print(' '+c) if isinstance(downloader, dict): print(' This tool might be automatically downloaded by KiBot.') show_roles(roles) @@ -443,7 +445,7 @@ for name, d in dependencies.items(): else: # TODO: check pip_ok and if this is a Python tool suggest install pip binary_tool(d['sev'], d['name'], d['url'], d['url_down'], d['deb_package'], d['in_debian'], d['extra_deb'], - d['roles'], d['downloader']) + d['roles'], d['downloader'], d['comments']) labels = ('ok', 'optional for an output', 'optional for general use', 'mandatory for an output', 'mandatory for general use') text = ', '.join([sev2color(c)+l+RESET for c, l in enumerate(labels)])