[Position][Removed] exclude_strange_footprints option

- It doesn't allow granular control over what is excluded
- Another mechanism is needed
This commit is contained in:
Salvador E. Tropea 2023-11-16 08:49:58 -03:00
parent a2607450a1
commit 91e6e14a88
3 changed files with 0 additions and 7 deletions

View File

@ -53,7 +53,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Basic support for regular list items (#480)
- Position:
- Experimental support for gerber position files (#500)
- KiKit auxiliary footprints used for panels excluded (#516)
- Help for the error levels
- Warnings:
- Explain about wrong dir/output separation (#493)

View File

@ -43,7 +43,6 @@ Parameters:
- ``dnf_filter`` :index:`: <pair: output - position - options; dnf_filter>` [string|list(string)='_none'] Name of the filter to mark components as not fitted.
A short-cut to use for simple cases where a variant is an overkill.
- ``exclude_strange_footprints`` :index:`: <pair: output - position - options; exclude_strange_footprints>` [boolean=true] Removes suspicious footprints. Currently removes footprints generated by KiKit to create the panel.
- ``gerber_board_edge`` :index:`: <pair: output - position - options; gerber_board_edge>` [boolean=false] Include the board edge in the gerber output.
- ``include_virtual`` :index:`: <pair: output - position - options; include_virtual>` [boolean=false] Include virtual components. For special purposes, not pick & place.
Note that virtual components is a KiCad 5 concept.

View File

@ -91,8 +91,6 @@ class PositionOptions(VariantOptions):
""" When generating the CSV quote all values, even numbers """
self.gerber_board_edge = False
""" Include the board edge in the gerber output """
self.exclude_strange_footprints = True
""" Removes suspicious footprints. Currently removes footprints generated by KiKit to create the panel """
super().__init__()
self._expand_id = 'position'
@ -274,9 +272,6 @@ class PositionOptions(VariantOptions):
for m in sorted(GS.get_modules(), key=lambda c: _ref_key(c.GetReference())):
ref = m.GetReference()
logger.debug('P&P ref: {}'.format(ref))
if self.exclude_strange_footprints and ref.startswith('KiKit_'):
logger.debug('- KiKit auxiliary, excluded')
continue
value = None
# Apply any filter or variant data
if comps_hash: