From d67f7aa3b4e97fffc8d5d97bd21ada30c336533c Mon Sep 17 00:00:00 2001 From: "Salvador E. Tropea" Date: Mon, 9 Oct 2023 06:40:19 -0300 Subject: [PATCH] [Blender Export][Fixed] Extra space in light type names Fixes #505 --- CHANGELOG.md | 1 + docs/samples/generic_plot.kibot.yaml | 2 +- docs/source/configuration/outputs/blender_export.rst | 2 +- kibot/out_blender_export.py | 2 +- 4 files changed, 4 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3cbd67e3..be981467 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -60,6 +60,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Blender export: - Rotations are now applied to the current view, not just the top view - Board/components not visible for small boards (See #484) + - Light type names (extra space) (#505) - update_xml with check_pcb_parity enabled: - Avoid errors for KiCad 6 using "Exclude from BoM" components. This limitation isn't found on KiCad 7. (#486) diff --git a/docs/samples/generic_plot.kibot.yaml b/docs/samples/generic_plot.kibot.yaml index a10d8de0..6306e8e6 100644 --- a/docs/samples/generic_plot.kibot.yaml +++ b/docs/samples/generic_plot.kibot.yaml @@ -152,7 +152,7 @@ outputs: pos_y: 0 # [number|string] Z position [m]. You can use `width`, `height` and `size` for PCB dimensions pos_z: 0 - # [string='POINT'] [POINT, SUN, SPOT, HEMI, AREA] Type of light. SUN lights will illuminate more evenly + # [string='POINT'] [POINT,SUN,SPOT,HEMI,AREA] Type of light. SUN lights will illuminate more evenly type: 'POINT' # [dict|list(dict)] Outputs to generate in the same run outputs: diff --git a/docs/source/configuration/outputs/blender_export.rst b/docs/source/configuration/outputs/blender_export.rst index 04da93f7..3f9ec340 100644 --- a/docs/source/configuration/outputs/blender_export.rst +++ b/docs/source/configuration/outputs/blender_export.rst @@ -135,7 +135,7 @@ Parameters: - ``pos_x`` :index:`: ` [number|string] X position [m]. You can use `width`, `height` and `size` for PCB dimensions. - ``pos_y`` :index:`: ` [number|string] Y position [m]. You can use `width`, `height` and `size` for PCB dimensions. - ``pos_z`` :index:`: ` [number|string] Z position [m]. You can use `width`, `height` and `size` for PCB dimensions. - - ``type`` :index:`: ` [string='POINT'] [POINT, SUN, SPOT, HEMI, AREA] Type of light. SUN lights will illuminate more evenly. + - ``type`` :index:`: ` [string='POINT'] [POINT,SUN,SPOT,HEMI,AREA] Type of light. SUN lights will illuminate more evenly. - ``outputs`` :index:`: ` [dict|list(dict)] Outputs to generate in the same run. diff --git a/kibot/out_blender_export.py b/kibot/out_blender_export.py index 7fc3c635..7b87e893 100644 --- a/kibot/out_blender_export.py +++ b/kibot/out_blender_export.py @@ -124,7 +124,7 @@ class BlenderLightOptions(BlenderObjOptions): super().__init__() with document: self.type = "POINT" - """ [POINT, SUN, SPOT, HEMI, AREA] Type of light. SUN lights will illuminate more evenly """ + """ [POINT,SUN,SPOT,HEMI,AREA] Type of light. SUN lights will illuminate more evenly """ self.energy = 0 """ How powerful is the light. Using 0 for POINT and SUN KiBot will try to use something useful """ self.add_to_doc('name', ' light', with_nl=False)