From eb37077843d5f7f02c49d40828c2b8470322e465 Mon Sep 17 00:00:00 2001 From: "Salvador E. Tropea" Date: Thu, 30 Nov 2023 06:36:20 -0300 Subject: [PATCH] [Internal Templates][Added] _KIBOT_PLOT_FOOTPRINT_REFS/VALUES For some reason JLCPCB has VALUES disabled, now the user can choose it. Closes #523 --- CHANGELOG.md | 2 ++ docs/source/configuration/imports.rst | 2 ++ kibot/resources/config_templates/Elecrow.kibot.yaml | 6 ++++-- kibot/resources/config_templates/FusionPCB.kibot.yaml | 6 ++++-- kibot/resources/config_templates/JLCPCB.kibot.yaml | 6 ++++-- kibot/resources/config_templates/P-Ban.kibot.yaml | 6 ++++-- kibot/resources/config_templates/PCBWay.kibot.yaml | 6 ++++-- 7 files changed, 24 insertions(+), 10 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index f90c1ed4..40e8280e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -23,6 +23,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 3DRender_bottom_straight: to generate simple and quick 3D renders. - _KIBOT_POS_DNF_FILTER option to JLCPCB. It now excludes components added by KiKit to create panels and can be customized. + - _KIBOT_PLOT_FOOTPRINT_REFS and _KIBOT_PLOT_FOOTPRINT_VALUES to + manufacturer templates. (#523) - Filters: - New `_rot_footprint_jlcpcb` internal filter to fix the JLCPCB bottom rotations. diff --git a/docs/source/configuration/imports.rst b/docs/source/configuration/imports.rst index ac290a60..855a6131 100644 --- a/docs/source/configuration/imports.rst +++ b/docs/source/configuration/imports.rst @@ -321,6 +321,8 @@ The manufacturer templates (Elecrow, FusionPCB, JLCPCB, P-Ban and PCBWay) suppor - **_KIBOT_MANF_DIR**: Target directory for the manufacturer outputs (default: **_KIBOT_IMPORT_DIR**) - **_KIBOT_MANF_DIR_COMP**: Target directory for the compressed manufacturer outputs (default: **_KIBOT_IMPORT_DIR**) - **_KIBOT_GERBER_LAYERS**: List of layers to use for the gerbers (default: a specially crafted list of layers) +- **_KIBOT_PLOT_FOOTPRINT_REFS**: Include the footprint references in the gerbers (default: true) +- **_KIBOT_PLOT_FOOTPRINT_VALUES: Include the footprint values in the gerbers (default: true, except for JLCPCB) The JLCPCB case is a little bit more complex and also supports: diff --git a/kibot/resources/config_templates/Elecrow.kibot.yaml b/kibot/resources/config_templates/Elecrow.kibot.yaml index 519ef968..0b695991 100644 --- a/kibot/resources/config_templates/Elecrow.kibot.yaml +++ b/kibot/resources/config_templates/Elecrow.kibot.yaml @@ -19,8 +19,8 @@ outputs: exclude_edge_layer: true exclude_pads_from_silkscreen: true plot_sheet_reference: false - plot_footprint_refs: true - plot_footprint_values: true + plot_footprint_refs: @_KIBOT_PLOT_FOOTPRINT_REFS@ + plot_footprint_values: @_KIBOT_PLOT_FOOTPRINT_VALUES@ force_plot_invisible_refs_vals: false tent_vias: true use_protel_extensions: true @@ -69,6 +69,8 @@ definitions: _KIBOT_IMPORT_DIR: 'Elecrow' _KIBOT_MANF_DIR: '@_KIBOT_IMPORT_DIR@' _KIBOT_MANF_DIR_COMP: '@_KIBOT_IMPORT_DIR@' + _KIBOT_PLOT_FOOTPRINT_REFS: true + _KIBOT_PLOT_FOOTPRINT_VALUES: true _KIBOT_GERBER_LAYERS: | - copper - F.SilkS diff --git a/kibot/resources/config_templates/FusionPCB.kibot.yaml b/kibot/resources/config_templates/FusionPCB.kibot.yaml index 4f8f165c..d27ef390 100644 --- a/kibot/resources/config_templates/FusionPCB.kibot.yaml +++ b/kibot/resources/config_templates/FusionPCB.kibot.yaml @@ -19,8 +19,8 @@ outputs: exclude_edge_layer: true exclude_pads_from_silkscreen: true plot_sheet_reference: false - plot_footprint_refs: true - plot_footprint_values: true + plot_footprint_refs: @_KIBOT_PLOT_FOOTPRINT_REFS@ + plot_footprint_values: @_KIBOT_PLOT_FOOTPRINT_VALUES@ force_plot_invisible_refs_vals: false tent_vias: true use_protel_extensions: true @@ -69,6 +69,8 @@ definitions: _KIBOT_IMPORT_DIR: 'FusionPCB' _KIBOT_MANF_DIR: '@_KIBOT_IMPORT_DIR@' _KIBOT_MANF_DIR_COMP: '@_KIBOT_IMPORT_DIR@' + _KIBOT_PLOT_FOOTPRINT_REFS: true + _KIBOT_PLOT_FOOTPRINT_VALUES: true _KIBOT_GERBER_LAYERS: | - copper - F.SilkS diff --git a/kibot/resources/config_templates/JLCPCB.kibot.yaml b/kibot/resources/config_templates/JLCPCB.kibot.yaml index aedb1112..40db9769 100644 --- a/kibot/resources/config_templates/JLCPCB.kibot.yaml +++ b/kibot/resources/config_templates/JLCPCB.kibot.yaml @@ -44,8 +44,8 @@ outputs: exclude_edge_layer: true exclude_pads_from_silkscreen: true plot_sheet_reference: false - plot_footprint_refs: true - plot_footprint_values: false + plot_footprint_refs: @_KIBOT_PLOT_FOOTPRINT_REFS@ + plot_footprint_values: @_KIBOT_PLOT_FOOTPRINT_VALUES@ force_plot_invisible_refs_vals: false tent_vias: true use_protel_extensions: true @@ -154,6 +154,8 @@ definitions: _KIBOT_POS_DNF_FILTER: _remove_extra _KIBOT_POS_ENABLED: true _KIBOT_BOM_ENABLED: true + _KIBOT_PLOT_FOOTPRINT_REFS: true + _KIBOT_PLOT_FOOTPRINT_VALUES: false _KIBOT_GERBER_LAYERS: | - copper - F.SilkS diff --git a/kibot/resources/config_templates/P-Ban.kibot.yaml b/kibot/resources/config_templates/P-Ban.kibot.yaml index 3450b3f8..9d1a6402 100644 --- a/kibot/resources/config_templates/P-Ban.kibot.yaml +++ b/kibot/resources/config_templates/P-Ban.kibot.yaml @@ -19,8 +19,8 @@ outputs: exclude_edge_layer: true exclude_pads_from_silkscreen: true plot_sheet_reference: false - plot_footprint_refs: true - plot_footprint_values: true + plot_footprint_refs: @_KIBOT_PLOT_FOOTPRINT_REFS@ + plot_footprint_values: @_KIBOT_PLOT_FOOTPRINT_VALUES@ force_plot_invisible_refs_vals: false tent_vias: true use_protel_extensions: true @@ -75,6 +75,8 @@ definitions: _KIBOT_IMPORT_DIR: 'P-Ban' _KIBOT_MANF_DIR: '@_KIBOT_IMPORT_DIR@' _KIBOT_MANF_DIR_COMP: '@_KIBOT_IMPORT_DIR@' + _KIBOT_PLOT_FOOTPRINT_REFS: true + _KIBOT_PLOT_FOOTPRINT_VALUES: true _KIBOT_GERBER_LAYERS: | - F.Cu - B.Cu diff --git a/kibot/resources/config_templates/PCBWay.kibot.yaml b/kibot/resources/config_templates/PCBWay.kibot.yaml index ccc3faff..7e33e434 100644 --- a/kibot/resources/config_templates/PCBWay.kibot.yaml +++ b/kibot/resources/config_templates/PCBWay.kibot.yaml @@ -19,8 +19,8 @@ outputs: exclude_edge_layer: true exclude_pads_from_silkscreen: true plot_sheet_reference: false - plot_footprint_refs: true - plot_footprint_values: true + plot_footprint_refs: @_KIBOT_PLOT_FOOTPRINT_REFS@ + plot_footprint_values: @_KIBOT_PLOT_FOOTPRINT_VALUES@ force_plot_invisible_refs_vals: false tent_vias: true use_protel_extensions: true @@ -77,6 +77,8 @@ definitions: _KIBOT_IMPORT_DIR: 'PCBWay' _KIBOT_MANF_DIR: '@_KIBOT_IMPORT_DIR@' _KIBOT_MANF_DIR_COMP: '@_KIBOT_IMPORT_DIR@' + _KIBOT_PLOT_FOOTPRINT_REFS: true + _KIBOT_PLOT_FOOTPRINT_VALUES: true _KIBOT_GERBER_LAYERS: | - copper - F.SilkS