From ef64a57697d8e53d815dd8f7bc3d9a7c14f47a37 Mon Sep 17 00:00:00 2001 From: "Salvador E. Tropea" Date: Mon, 15 Jun 2020 15:17:09 -0300 Subject: [PATCH] Documented the fact that current kicad2step program never fails. Well, it fails, but returns 0. --- kiplot/kiplot.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/kiplot/kiplot.py b/kiplot/kiplot.py index 34158263..418667c8 100644 --- a/kiplot/kiplot.py +++ b/kiplot/kiplot.py @@ -639,7 +639,9 @@ class Plotter(object): logger.debug('Executing: '+str(cmd)) try: cmd_output = check_output(cmd, stderr=STDOUT) - except CalledProcessError as e: + except CalledProcessError as e: # pragma: no cover + # Current kicad2step always returns 0!!!! + # This is why I'm excluding it from coverage logger.error('Failed to create Step file, error %d', e.returncode) if e.output: logger.debug('Output from command: '+e.output.decode())