From fee5bce8816efa699f4991130d3db84f3f07c788 Mon Sep 17 00:00:00 2001
From: "Salvador E. Tropea" <salvador@inti.gob.ar>
Date: Wed, 20 Apr 2022 20:38:14 -0300
Subject: [PATCH] Added warnings for ridiculous OAR values on pads

Related to #164
---
 kibot/misc.py       |  1 +
 kibot/out_report.py | 20 ++++++++++++++++++--
 2 files changed, 19 insertions(+), 2 deletions(-)

diff --git a/kibot/misc.py b/kibot/misc.py
index 95b69a07..168bd278 100644
--- a/kibot/misc.py
+++ b/kibot/misc.py
@@ -233,6 +233,7 @@ W_WRONGEXT = '(W083) '
 W_COLORTHEME = '(W084) '
 W_WRONGCOLOR = '(W085) '
 W_WKSVERSION = '(W086) '
+W_WRONGOAR = '(W087) '
 # Somehow arbitrary, the colors are real, but can be different
 PCB_MAT_COLORS = {'fr1': "937042", 'fr2': "949d70", 'fr3': "adacb4", 'fr4': "332B16", 'fr5': "6cc290"}
 PCB_FINISH_COLORS = {'hal': "8b898c", 'hasl': "8b898c", 'imag': "8b898c", 'enig': "cfb96e", 'enepig': "cfb96e",
diff --git a/kibot/out_report.py b/kibot/out_report.py
index 864b2e00..a284326d 100644
--- a/kibot/out_report.py
+++ b/kibot/out_report.py
@@ -10,7 +10,7 @@ from subprocess import check_output, STDOUT, CalledProcessError
 
 from .gs import GS
 from .misc import (UI_SMD, UI_VIRTUAL, MOD_THROUGH_HOLE, MOD_SMD, MOD_EXCLUDE_FROM_POS_FILES, PANDOC, MISSING_TOOL,
-                   FAILED_EXECUTE, W_WRONGEXT)
+                   FAILED_EXECUTE, W_WRONGEXT, W_WRONGOAR)
 from .registrable import RegOutput
 from .out_base import BaseOptions
 from .error import KiPlotConfigurationError
@@ -31,6 +31,10 @@ def do_round(v, dig):
 
 def to_mm(iu, dig=2):
     """ KiCad Internal Units to millimeters """
+    if isinstance(iu, pcbnew.wxPoint):
+        return (do_round(iu.x/pcbnew.IU_PER_MM, dig), do_round(iu.y/pcbnew.IU_PER_MM, dig))
+    if isinstance(iu, pcbnew.wxSize):
+        return (do_round(iu.x/pcbnew.IU_PER_MM, dig), do_round(iu.y/pcbnew.IU_PER_MM, dig))
     return do_round(iu/pcbnew.IU_PER_MM, dig)
 
 
@@ -116,6 +120,12 @@ def solve_edge_connector(val):
     return val
 
 
+def get_pad_info(pad):
+    return ("Position {} on layer {}, size {} drill size {}".
+            format(to_mm(pad.GetPosition()), GS.board.GetLayerName(pad.GetLayer()),
+                   to_mm(pad.GetSize(), 4), to_mm(pad.GetDrillSize(), 4)))
+
+
 class ReportOptions(BaseOptions):
     def __init__(self):
         with document:
@@ -445,6 +455,7 @@ class ReportOptions(BaseOptions):
         bottom_layer = board.GetLayerID('B.Cu')
         is_pure_smd, is_not_virtual = self.get_attr_tests()
         npth_attrib = 3 if GS.ki5() else pcbnew.PAD_ATTRIB_NPTH
+        min_oar = 0.1*pcbnew.IU_PER_MM
         for m in modules:
             layer = m.GetLayer()
             if layer == top_layer:
@@ -482,8 +493,13 @@ class ReportOptions(BaseOptions):
                 oar_x = pad_sz.x - (dr.x+adjust)
                 oar_y = pad_sz.y - (dr.y+adjust)
                 oar_t = min(oar_x, oar_y)
-                if oar_t:
+                if oar_t > 0:
                     self.oar_pads = min(self.oar_pads, oar_t)
+                    if oar_t < min_oar:
+                        logger.warning(W_WRONGOAR+"Really small OAR detected ({} mm) for pad {}".
+                                       format(to_mm(oar_t, 4), get_pad_info(pad)))
+                elif oar_t < 0:
+                    logger.warning(W_WRONGOAR+"Negative OAR detected for pad "+get_pad_info(pad))
         self._vias_m = sorted(self._vias.keys())
         # Via Pad size
         self.via_pad_d = ds.m_ViasMinSize