From e2184f035115071a2407b15f225eb153c1765a3a Mon Sep 17 00:00:00 2001 From: Xudong Zheng <7pkvm5aw@slicealias.com> Date: Tue, 21 Jan 2025 00:27:50 -0500 Subject: [PATCH] fix(underglow): allow full range for initial brightness The brightness is already scaled within zmk_rgb_underglow_tick(). With the current range condition, setting max brightness to 20% results in starting with 4% (20% of 20%) brightness. --- app/Kconfig | 2 +- app/Kconfig.defaults | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/Kconfig b/app/Kconfig index 5fc03822a..509083796 100644 --- a/app/Kconfig +++ b/app/Kconfig @@ -314,7 +314,7 @@ config ZMK_RGB_UNDERGLOW_SAT_START config ZMK_RGB_UNDERGLOW_BRT_START int "RGB underglow start brightness value in percent" - range ZMK_RGB_UNDERGLOW_BRT_MIN ZMK_RGB_UNDERGLOW_BRT_MAX + range 0 100 config ZMK_RGB_UNDERGLOW_SPD_START int "RGB underglow start animation speed value" diff --git a/app/Kconfig.defaults b/app/Kconfig.defaults index 02d845f1b..beb6a13f6 100644 --- a/app/Kconfig.defaults +++ b/app/Kconfig.defaults @@ -44,7 +44,7 @@ config ZMK_RGB_UNDERGLOW_SAT_START default 100 config ZMK_RGB_UNDERGLOW_BRT_START - default ZMK_RGB_UNDERGLOW_BRT_MAX + default 100 config ZMK_RGB_UNDERGLOW_SPD_START default 3